Conversation
Member
There was a problem hiding this comment.
Could you modify the test to make the b'a' token on its own line? Something like:
enum X {
A =
b'a' //~ ERROR: ...
,
B(int)
}
bors
added a commit
that referenced
this pull request
Sep 21, 2014
ghost
deleted the
issue-17383
branch
October 2, 2014 20:24
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2024
…eykril fix: Only show unlinked-file diagnostic on first line during startup This partially reverts rust-lang#17350, based on the feedback in rust-lang#17397. If we don't have an autofix, it's more annoying to highlight the whole file. This autofix heuristic fixes the diagnostic being overwhelming during startup.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 23, 2026
…lizers (rust-lang#17415) Fixes rust-lang/rust-clippy#13910. `ref_as_ptr` can suggest `std::ptr::from_ref`/`std::ptr::from_mut` for nested reference-to-raw-pointer casts inside `const` and `static` initializers. The suggested replacement then fails during const evaluation. The existing guard only checks the immediate expression use site, which misses nested cast expressions. Extend it to also check whether the expression is inside an always-const context using `is_inside_always_const_context`. ### Testing - Added a regression test reproducing the reported nested `static mut` case. - Ran the `ref_as_ptr` UI tests. changelog: [`ref_as_ptr`]: avoid invalid suggestions in const/static initializers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17383.