Skip to content

Omit integer suffix when unnecessary - #21710

Merged
bors merged 1 commit into
rust-lang:masterfrom
alfiedotwtf:libsyntax
Feb 3, 2015
Merged

Omit integer suffix when unnecessary#21710
bors merged 1 commit into
rust-lang:masterfrom
alfiedotwtf:libsyntax

Conversation

@alfiedotwtf

Copy link
Copy Markdown
Contributor

See PR # 21378 for context

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nick29581

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc

nrc commented Jan 28, 2015

Copy link
Copy Markdown
Member

@bors: r+ ad20f5ae444afba3792ee15c6d59dc4b2e64925c

@frewsxcv

Copy link
Copy Markdown
Contributor

Needs a rebase

See PR # 21378 for context
@alfiedotwtf

Copy link
Copy Markdown
Contributor Author

Ping @frewsxcv

@frewsxcv

frewsxcv commented Feb 2, 2015

Copy link
Copy Markdown
Contributor

@Alfie I unfortunately do not have reviewing rights :P You might need @nick29581 for that

@alfiedotwtf

Copy link
Copy Markdown
Contributor Author

Sorry @frewsxcv :)

@nrc

nrc commented Feb 2, 2015

Copy link
Copy Markdown
Member

@bors r+ 9683745

@alfiedotwtf

Copy link
Copy Markdown
Contributor Author

Sorry, I didn't realise force push didn't notify.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Feb 2, 2015
Conflicts:
	src/libsyntax/parse/parser.rs
@bors

bors commented Feb 2, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9683745 with merge 2b0fd75...

@bors

bors commented Feb 2, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton

Copy link
Copy Markdown
Member

@bors: retry

@alfiedotwtf

Copy link
Copy Markdown
Contributor Author

@alexcrichton any idea why homu stopped?

@alexcrichton

Copy link
Copy Markdown
Member

Ah I canceled it manually because this is included in the rollup (#21872) and wanted to put the rollup back on bors.

@alfiedotwtf

Copy link
Copy Markdown
Contributor Author

Ahh cool, np :)

@bors
bors merged commit 9683745 into rust-lang:master Feb 3, 2015
@alfiedotwtf
alfiedotwtf deleted the libsyntax branch February 3, 2015 11:36
lnicola pushed a commit to lnicola/rust that referenced this pull request Feb 28, 2026
Migrate fix_visibility assist to use SyntaxEditor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants