rustc_back: Don't pass 'u' to ar invocations - #25411
Merged
Merged
Conversation
Contributor
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
r? @brson This will tangentially fix the MUSL builds on the bots right now. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit ae13436 has been approved by |
Collaborator
|
☔ The latest upstream changes (presumably #25350) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
🔒 Merge conflict |
This flag indicates that when files are being replaced or added to archives (the `r` flag) that the new file should not be inserted if it is not newer than the file that already exists in the archive. The compiler never actually has a use case of *not* wanting to insert a file because it already exists, and this causes rlibs to not be updated in some cases when the compiler was re-run too quickly. Closes rust-lang#18913
Member
Author
Collaborator
bors
added a commit
that referenced
this pull request
May 26, 2015
This flag indicates that when files are being replaced or added to archives (the `r` flag) that the new file should not be inserted if it is not newer than the file that already exists in the archive. The compiler never actually has a use case of *not* wanting to insert a file because it already exists, and this causes rlibs to not be updated in some cases when the compiler was re-run too quickly. Closes #18913
Collaborator
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Oct 10, 2017
cargo_rustc: remove workaround for fixed upstream issue Fixed in rust-lang/rust#25411. Also, the removed code is implicated in test failures observed in rust-lang/rust#44515. r? @alexcrichton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag indicates that when files are being replaced or added to archives (the
rflag) that the new file should not be inserted if it is not newer than thefile that already exists in the archive. The compiler never actually has a use
case of not wanting to insert a file because it already exists, and this
causes rlibs to not be updated in some cases when the compiler was re-run too
quickly.
Closes #18913