Skip to content

Fix #27567: remove --crate-type=lib from pretty test - #27571

Merged
bors merged 2 commits into
rust-lang:masterfrom
TimNN:pretty-no-crate-type
Aug 11, 2015
Merged

Fix #27567: remove --crate-type=lib from pretty test#27571
bors merged 2 commits into
rust-lang:masterfrom
TimNN:pretty-no-crate-type

Conversation

@TimNN

@TimNN TimNN commented Aug 6, 2015

Copy link
Copy Markdown
Contributor

Because I wanted to change the pretty test as little as possible I added // compiler-flags: --crate-type=lib to those test that failed because of a missing main. Passes make check-stage1-pretty locally.

cc @nrc
cc #27567

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson

brson commented Aug 6, 2015

Copy link
Copy Markdown
Contributor

@bors r+ Nice cleanup.

@bors

bors commented Aug 6, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 9fd0845 has been approved by brson

@bors

bors commented Aug 6, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fd0845 with merge 516a1a3...

@bors

bors commented Aug 7, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-32-opt

@TimNN

TimNN commented Aug 7, 2015

Copy link
Copy Markdown
Contributor Author

So, travis passed and homu failed with an Illegal instruction during compile-fail, which seems to be totally unrelated to any of my changes. Is this just a sporadic failure or is there some action required on my part?

@nrc

nrc commented Aug 9, 2015

Copy link
Copy Markdown
Member

@bors: retry

@bors

bors commented Aug 9, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fd0845 with merge 3b232d6...

@nrc

nrc commented Aug 9, 2015

Copy link
Copy Markdown
Member

Travis only runs make tidy so doesn't mean much. The c-fail error could be legit, or perhaps not, we'll see...

@TimNN

TimNN commented Aug 9, 2015

Copy link
Copy Markdown
Contributor Author

@nrc Since some time ago, travis actually runs make check! https://github.com/rust-lang/rust/blob/master/.travis.yml#L23

@nrc

nrc commented Aug 9, 2015

Copy link
Copy Markdown
Member

oh, neat!

@bors

bors commented Aug 9, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-32-opt

@TimNN

TimNN commented Aug 9, 2015

Copy link
Copy Markdown
Contributor Author

Looks like #27619

@dotdash

dotdash commented Aug 10, 2015

Copy link
Copy Markdown
Contributor

@bors retry

@TimNN
TimNN force-pushed the pretty-no-crate-type branch from 9fd0845 to f0ea2b6 Compare August 11, 2015 11:00
bors added a commit that referenced this pull request Aug 11, 2015
@TimNN

TimNN commented Aug 11, 2015

Copy link
Copy Markdown
Contributor Author

Seeing as travis passed again, this should be fine now after the fail as part of the rollup (#27658 (comment))

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ f0ea2b6

bors added a commit that referenced this pull request Aug 11, 2015
Because I wanted to change the pretty test as little as possible I added `// compiler-flags: --crate-type=lib` to those test that failed because of a missing `main`. Passes `make check-stage1-pretty` locally.

cc @nrc
cc #27567
@bors

bors commented Aug 11, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f0ea2b6 with merge dcdcc6f...

@bors

bors commented Aug 11, 2015

Copy link
Copy Markdown
Collaborator

⛄ The build was interrupted to prioritize another pull request.

@bors

bors commented Aug 11, 2015

Copy link
Copy Markdown
Collaborator

@bors
bors merged commit f0ea2b6 into rust-lang:master Aug 11, 2015
@TimNN
TimNN deleted the pretty-no-crate-type branch September 6, 2015 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants