Skip to content

Disable jemalloc on aarch64/powerpc - #37392

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:more-disable-jemalloc
Oct 30, 2016
Merged

Disable jemalloc on aarch64/powerpc#37392
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:more-disable-jemalloc

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.

Closes #36994
Closes #37320
cc jemalloc/jemalloc#467

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
Member Author

r? @brson

@xen0n

xen0n commented Oct 25, 2016

Copy link
Copy Markdown
Contributor

Multiple page sizes are also present on MIPS, both the 32- and 64-bit variants. Would be a good idea to include those too. :-)

@alexcrichton
alexcrichton force-pushed the more-disable-jemalloc branch from c0ca239 to 0f6fde2 Compare October 25, 2016 15:56
@alexcrichton

Copy link
Copy Markdown
Member Author

@xen0n ah, sounds good to protect against as well! I've disabled it there as well.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis failed because all these MIPS additions should end in commas, not semicolons.

Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.

Closes rust-lang#36994
Closes rust-lang#37320
cc jemalloc/jemalloc#467
@alexcrichton
alexcrichton force-pushed the more-disable-jemalloc branch from 0f6fde2 to de80670 Compare October 27, 2016 15:08
@brson

brson commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 27, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit de80670 has been approved by brson

@sfackler

Copy link
Copy Markdown
Member

omg jemalloc

@bors

bors commented Oct 29, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit de80670 with merge 62bdf88...

bors added a commit that referenced this pull request Oct 29, 2016
Disable jemalloc on aarch64/powerpc

Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.

Closes #36994
Closes #37320
cc jemalloc/jemalloc#467
@bors

bors commented Oct 30, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-opt

@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: retry

On Sat, Oct 29, 2016 at 8:28 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/10825


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#37392 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95PIffOMf5PiEF3ArjsytuI7F0F2gks5q4-SZgaJpZM4Kff3U
.

@bors

bors commented Oct 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit de80670 with merge aef5ca5...

bors added a commit that referenced this pull request Oct 30, 2016
Disable jemalloc on aarch64/powerpc

Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.

Closes #36994
Closes #37320
cc jemalloc/jemalloc#467
@bors
bors merged commit de80670 into rust-lang:master Oct 30, 2016
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 30, 2016
@alexcrichton
alexcrichton deleted the more-disable-jemalloc branch November 6, 2016 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes Marks issues that should be documented in the release notes of the next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants