Skip to content

[libstd_unicode] Upgrade to Unicode 10.0.0 - #42999

Merged
bors merged 1 commit into
rust-lang:masterfrom
behnam:ucd10
Jul 3, 2017
Merged

[libstd_unicode] Upgrade to Unicode 10.0.0#42999
bors merged 1 commit into
rust-lang:masterfrom
behnam:ucd10

Conversation

@behnam

@behnam behnam commented Jun 30, 2017

Copy link
Copy Markdown
Contributor

Update libstd_unicode's data tables to Unicode 10.0.0, as released on 2017 June 20: http://www.unicode.org/versions/Unicode10.0.0/

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jonas-schievink

Copy link
Copy Markdown
Contributor
// NOTE: The following code was generated by "./unicode.py", do not edit directly

@behnam

behnam commented Jun 30, 2017

Copy link
Copy Markdown
Contributor Author

@jonas-schievink, I ran the script to generate the file. I didn't mention that part because I thought it's obvious.

In #42998, I applied the change manually, because running the script also causes these changes. So, we can apply #42998 after this one, hopefully, to avoid breaking any instructions, theoretically.

@behnam

behnam commented Jun 30, 2017

Copy link
Copy Markdown
Contributor Author

CC'ing from file's blame/history: @petrochenkov, @cuviper, @alexcrichton, @SimonSapin

@jonas-schievink

Copy link
Copy Markdown
Contributor

Oh, nevermind then, I thought you'd have to do some changes to the script itself.

@behnam

behnam commented Jun 30, 2017

Copy link
Copy Markdown
Contributor Author

Yeah, the script always fetches the latest version and there's no CLI option to change that. I think we should fix that, so we don't have to upgrade if we don't want to. (We don't keep the text data files in the repo.)

So, is there any reason to keep it as it is, or can I send a PR?

@Mark-Simulacrum

Copy link
Copy Markdown
Member

r? @alexcrichton -- I think this falls more into libs

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2017
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

Thanks @behnam!

@bors

bors commented Jul 3, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit a6994d7 has been approved by alexcrichton

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 3, 2017
@bors

bors commented Jul 3, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a6994d7 with merge 734c836...

bors added a commit that referenced this pull request Jul 3, 2017
[libstd_unicode] Upgrade to Unicode 10.0.0

Update `libstd_unicode`'s data tables to Unicode 10.0.0, as released on 2017 June 20: http://www.unicode.org/versions/Unicode10.0.0/
@bors

bors commented Jul 3, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 734c836 to master...

@bors
bors merged commit a6994d7 into rust-lang:master Jul 3, 2017
@behnam
behnam deleted the ucd10 branch July 3, 2017 20:55
@H2CO3

H2CO3 commented Sep 7, 2017

Copy link
Copy Markdown

Could you please check rust-lang/regex#391 as well. The regex crate would benefit from more recent Unicode compatibility as well.

@cuviper

cuviper commented Sep 7, 2017

Copy link
Copy Markdown
Member

See rust-lang/regex#400 for Unicode 10.0.

@H2CO3

H2CO3 commented Sep 7, 2017

Copy link
Copy Markdown

@cuviper Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants