Update libc and some fixes for x86_64-unknown-linux-gnux32 - #45391
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
The libstd tests fails in my machine, let's see on travis. |
There was a problem hiding this comment.
We've got existing tests for x86/x86_64, perhaps those could just switch to being two tests based on target_pointer_width?
There was a problem hiding this comment.
Is this necessary b/c the values are always < 1e9? Doesn't that mean we can basically cast to "anything reasonable" here and expect it to work?
There was a problem hiding this comment.
Should we use i32?
There was a problem hiding this comment.
I think that could work? It just seemed like the extra casting wasn't necessary here given the various constraints.
There was a problem hiding this comment.
As subsec_nanos is u32, I opted to use u32. Both i32 and u32 are fine.
There was a problem hiding this comment.
Do you plan on leaving this permanently? It looks like we don't have a lot of extra time on this builder unfortunately (the last one clocked in at 1h40m)...
I'd imagine though that once we get the test suite passing once it's probably pretty unlikely to regress?
|
Looks like maybe something related to stack walking is odd? |
|
@alexcrichton I squashed the commits and disable the gnux32 tests. I also opened the issue #45416 to track the failures. |
|
Ok! Is this ready to go? (did you mean to add ignore annotations to all affected tests?) |
|
I think this is ready to go. This will allows others to test the target with the fixed libc. I think you are correct about the stack walk odds. I will be out for some time now, but it would be great if someone could take a look at it. |
|
@bors: r+ |
|
📌 Commit e57ee3d has been approved by |
Update libc and some fixes for x86_64-unknown-linux-gnux32
|
☀️ Test successful - status-appveyor, status-travis |
No description provided.