Skip to content

Add a ui test for an incorrect Result success type in a #[test] - #50272

Merged
bors merged 1 commit into
rust-lang:masterfrom
scottmcm:termination-test-error
Apr 30, 2018
Merged

Add a ui test for an incorrect Result success type in a #[test]#50272
bors merged 1 commit into
rust-lang:masterfrom
scottmcm:termination-test-error

Conversation

@scottmcm

Copy link
Copy Markdown
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2018
LL | / fn can_parse_zero_as_f32() -> Result<f32, ParseIntError> { //~ ERROR
LL | | "0".parse()
LL | | }
| |_^ `main` can only return types that implement `std::process::Termination`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, that message is a bit off, isn't it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, the span stinks =)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but let's add it anyway and file a follow-up bug

@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Apr 27, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f0069b8 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2018
@bors

bors commented Apr 30, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f0069b8 with merge 7fbc4d8...

bors added a commit that referenced this pull request Apr 30, 2018
Add a ui test for an incorrect Result success type in a #[test]

cc #48854 (comment)
r? @nikomatsakis
@bors

bors commented Apr 30, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 7fbc4d8 to master...

@bors
bors merged commit f0069b8 into rust-lang:master Apr 30, 2018
@scottmcm
scottmcm deleted the termination-test-error branch April 18, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants