Replaced calls to external fmin/fmax by a Rust implementation. - #6803
Closed
Thiez wants to merge 2 commits into
Closed
Replaced calls to external fmin/fmax by a Rust implementation.#6803Thiez wants to merge 2 commits into
Thiez wants to merge 2 commits into
Conversation
bors
added a commit
that referenced
this pull request
May 29, 2013
Calls to the libc versions of fmin and fmax were relatively slow (perhaps because they could not be inlined?). This pull request provides f32 and f64 with fmin and fmax written in Rust, and shows a significant speed increase on my system; I used https://github.com/thiez/rustray as my benchmark, with --opt-level 3 it brings the ray-tracing time down from 10.8 seconds to about 9.2, which seemed significant to me. r?
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 25, 2021
Fixes rust-lang#6803 changelog: upper_case_acronyms: ignore public items
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 25, 2021
upper_case_acronyms: don't warn on public items Fixes rust-lang#6803 changelog: upper_case_acronyms: ignore public items
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 8, 2021
disable upper_case_acronyms for pub items - enum edition Fixes rust-lang/rust-clippy#6803 (again... 😅 ) My previous fix did not work for enums because enum variants were checked separately in the `check_variant` function but it looks like we can't use that because we can't tell if the enum the variants belong to is declared as public or not (it always said `Inherited` for me) I went and special-cased enums and iterated over all the variants "manually", but only, if the enums is not public. --- changelog: fix upper_case_acronyms still firing on public enums (rust-lang#6803)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls to the libc versions of fmin and fmax were relatively slow (perhaps because they could not be inlined?). This pull request provides f32 and f64 with fmin and fmax written in Rust, and shows a significant speed increase on my system; I used https://github.com/thiez/rustray as my benchmark, with --opt-level 3 it brings the ray-tracing time down from 10.8 seconds to about 9.2, which seemed significant to me.
r?