mk: add mechanisms for triggering clean-llvm builds from commits - #7442
Merged
Conversation
bors
added a commit
that referenced
this pull request
Jun 29, 2013
This makes it possible for us to trigger the llvm-clean make-target by checking in a change that touches rustllvm/llvm-auto-clean-stamp. Most developers don't need to see or know about this, but when you push a change that "needs an LLVM rebuild", even if not otherwise obvious, this should give a mechanism to do it.
bors
added a commit
that referenced
this pull request
Jul 1, 2013
fix clean-llvm in mk/clean.mk for cross-compile after #7442 landed, below error produced while android cross-compile ``` make[1]: *** No rule to make target `clean-llvmarm-linux-androideabi', needed by `clean-llvm'. Stop. make[1]: Leaving directory `/home/yichoi/rust_latest/build' make: *** [rustllvm/llvm-auto-clean-stamp] Error 2 ```
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 15, 2021
Refactor `format_args!` expansion parsing Introduces `FormatExpn::parse` and `FormatArgsExpn::parse`. Motivated by rust-lang#83302, so I only have to change Clippy in one place. Fixed an FP along the way. I also allowed `needless_bool` in macros because I often want to do `if_chain! { .. then { true } else { false } }`. changelog: Fix false positive in `useless_format` when some text is appended or prepended to a single string with some useless formatting params changelog: Allow `needless_bool` in macros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible for us to trigger the llvm-clean make-target by checking in a change that touches rustllvm/llvm-auto-clean-stamp. Most developers don't need to see or know about this, but when you push a change that "needs an LLVM rebuild", even if not otherwise obvious, this should give a mechanism to do it.