Fix details rustdoc toggle for blanket impl - #85860
Conversation
In the meantime, allow all of the details to have the same top.
|
Some changes occurred in HTML/CSS/JS. |
|
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I can't find any difference between the screenshots. Could you describe what this fix is doing please? |
|
@GuillaumeGomez Sorry I didn't describe it clearly. Look at the |
|
Oh I see. Do you have a screenshot when an item has an attribute too please? |
|
I thought it is quite obvious though. I think you should play more https://cantunsee.space/ |
|
It should be the same, that path is taken care by the general css if it was already there. (lazy to do the screenshot since it should be the same, I am tweaking the css in browser T_T) |
|
Checked locally and it works as expected, thanks! @bors: r+ rollup |
|
📌 Commit 2970479 has been approved by |
bors
added
S-waiting-on-bors
Just wondering, how you tried it out locally? |
|
I updated the two lines of CSS in my browser. :) |
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#85473 (fix split-debuginfo error message) - rust-lang#85622 (Remove toggle for "undocumented items.") - rust-lang#85826 (Mention "null pointer optimization" in option docs.) - rust-lang#85860 (Fix details rustdoc toggle for blanket impl) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
6 participants
In the meantime, allow all of the details to have the same top.
Before
After
I stumbled across this while wanting to do a details button for the layout.