Error code cleanup and enforce checks - #86137
Merged
Merged
Conversation
GuillaumeGomez
added
the
A-error-codes
Contributor
|
Some changes occurred in diagnostic error codes |
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
Member
There was a problem hiding this comment.
r=me with nit resolved
Mark-Simulacrum
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
error-code-cleanup
branch
from
June 23, 2021 14:42
fb44052 to
03330ff
Compare
Member
Author
|
@bors: r=Mark-Simulacrum |
Collaborator
|
📌 Commit 03330ff9d1d88656c4a02f211b995b16e00b510d has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 03330ff9d1d88656c4a02f211b995b16e00b510d with merge 74a7631fe4e17c36de0b42047db0911e316384ea... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
error-code-cleanup
branch
from
June 23, 2021 19:33
03330ff to
20f1b1c
Compare
Member
Author
|
This is intriguing: when running locally, no issue. Well I rebased, let's try again... @bors: r=Mark-Simulacrum |
Collaborator
|
📌 Commit 20f1b1c has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 20f1b1c with merge d2f2573cc638950c51c6f6e0bbf61662c99d0c43... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
|
The problem was that I checked for paths containing slashes whereas windows use backslash (which also explains why I couldn't trigger the error locally). @bors: r=Mark-Simulacrum |
Collaborator
|
📌 Commit 0ab9d01 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 0ab9d01 with merge 64ddfb3ccbb149f174f2ad8ed873cf88e7fa5c34... |
Member
|
@bors retry rolled-up |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#86137 (Error code cleanup and enforce checks) - rust-lang#86296 (Add documentation for various THIR structs) - rust-lang#86415 (Document associativity of iterator folds.) - rust-lang#86533 (Support lowercase error codes in `--explain`) - rust-lang#86536 (Edition 2021 enables disjoint capture) - rust-lang#86560 (Update cargo) - rust-lang#86561 (chore(rustdoc): Remove unused impl block) - rust-lang#86566 (Use `use_verbose` for `mir::Constant`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #86097.
It now checks if an error code is unused, and if so, will report an error if the error code wasn't commented out in the
error_codes.rsfile. It also checks that the constant used in the tidy check is up-to-date.r? @Mark-Simulacrum