Skip to content

Remove git fetch from CI - #87792

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:ci-fetch
Aug 15, 2021
Merged

Remove git fetch from CI#87792
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:ci-fetch

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Aug 5, 2021

Copy link
Copy Markdown
Member

#86623 added a call to git fetch, which is problematic for releases.

r? @pietroalbini

@GuillaumeGomez GuillaumeGomez added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Aug 5, 2021
@rust-highfive

rust-highfive commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2021
@GuillaumeGomez
GuillaumeGomez marked this pull request as ready for review August 5, 2021 13:24
@GuillaumeGomez GuillaumeGomez added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2021
syvb
syvb reviewed Aug 5, 2021
View reviewed changes

@syvb syvb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to include this commit, this error shouldn't be removed?

@GuillaumeGomez

GuillaumeGomez commented Aug 5, 2021

Copy link
Copy Markdown
Member Author

This commit is here to make the CI fail. As long as the CI isn't failing, then the PR isn't working.

@GuillaumeGomez
GuillaumeGomez force-pushed the ci-fetch branch 4 times, most recently from 8683162 to 450a097 Compare August 5, 2021 18:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez

GuillaumeGomez commented Aug 5, 2021

Copy link
Copy Markdown
Member Author

It's working. \o/ Removing the extra commit now...

@GuillaumeGomez

GuillaumeGomez commented Aug 5, 2021

Copy link
Copy Markdown
Member Author

cc @Mark-Simulacrum btw

@GuillaumeGomez GuillaumeGomez added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2021
@emilyalbini

emilyalbini commented Aug 14, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 14, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit c15bc2e has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2021
@bors

bors commented Aug 15, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c15bc2e with merge 909ab2635d564071e7525d8106a2934d6eecde3d...

@bors

bors commented Aug 15, 2021

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2021
@rust-log-analyzer

rust-log-analyzer commented Aug 15, 2021

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@GuillaumeGomez

GuillaumeGomez commented Aug 15, 2021

Copy link
Copy Markdown
Member Author

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87792 - GuillaumeGomez:ci-fetch, r=pietroal…
8feadd7 
…bini

Remove git fetch from CI

rust-lang#86623 added a call to `git fetch`, which is problematic for releases.

r? `@pietroalbini`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87792 - GuillaumeGomez:ci-fetch, r=pietroal…
defc49a 
…bini

Remove git fetch from CI

rust-lang#86623 added a call to `git fetch`, which is problematic for releases.

r? ``@pietroalbini``
This was referenced Aug 15, 2021
Closed
Closed
@bors

bors commented Aug 15, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c15bc2e with merge c0490a2...

@bors

bors commented Aug 15, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing c0490a2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 15, 2021
@bors
bors merged commit c0490a2 into rust-lang:master Aug 15, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 15, 2021
@GuillaumeGomez
GuillaumeGomez deleted the ci-fetch branch August 15, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@syvb syvb syvb left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@emilyalbini emilyalbini

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez @rust-highfive @rust-log-analyzer @emilyalbini @bors @syvb @rustbot