Fix HashMap not displaying correctly in VS debugger - #93626
Merged
Conversation
The natvis to render HashMaps was not working correctly in Visual Studio because the type names for tuples changed from `tuple$<A, B>` to `tuple$<A,B>` (notice the missing space). WinDbg and cdb continued to parse this type name which is why no tests in CI broke. VS however is slightly more strict and this caused the visualizer to break. Since we cannot test the VS debugger in CI, I'm not checking in any test changes.
rust-highfive
added
the
S-waiting-on-review
wesleywiser
added
A-debuginfo
Member
Yuck! 😄 Thanks for the PR, @wesleywiser! @bors r+ rollup=never (excluding from rollups because debuginfo test) |
Collaborator
|
📌 Commit fa99aaa has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit fa99aaa with merge ff3d374e48bbe8270a77959efed26c50c332a808... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Member
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
⌛ Testing commit fa99aaa with merge c508b9ada4a130b90672443889efa1729b0b3858... |
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit fa99aaa with merge 57c857a05be590bdd03c43d1d799b923892937b0... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
|
@bors retry Rustdoc gui test failure |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit fa99aaa with merge ca6439d520e13b93559960f5762a172a2a338784... |
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (775e480): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The natvis to render HashMaps was not working correctly in Visual Studio
because the type names for tuples changed from
tuple$<A, B>totuple$<A,B>(notice the missing space). WinDbg and cdb continued toparse this type name which is why no tests in CI broke. VS however is
slightly more strict and this caused the visualizer to break.
Since we cannot test the VS debugger in CI, I'm not checking in any
test changes.
Fixes #92286
r? @michaelwoerister