set filemode for chrome-sandbox executable during package - #254
Merged
Conversation
|
If you want to compare your solution to electron's builder, check out updateSandboxHelperPermissions |
shiftkey
force-pushed
the
set-file-mode-for-sandbox
branch
from
April 16, 2020 15:16
7e361de to
8fbd606
Compare
Owner
Author
@jfgordon2 yep, that's the one I used for inspiration for this change |
shiftkey
marked this pull request as ready for review
April 16, 2020 16:42
Owner
Author
|
Looks like |
shiftkey
added a commit
that referenced
this pull request
Apr 16, 2020
shiftkey
added a commit
that referenced
this pull request
Apr 16, 2020
shiftkey
added a commit
that referenced
this pull request
Apr 17, 2020
shiftkey
added a commit
that referenced
this pull request
Apr 23, 2020
shiftkey
added a commit
that referenced
this pull request
Apr 29, 2020
shiftkey
added a commit
that referenced
this pull request
May 1, 2020
shiftkey
added a commit
that referenced
this pull request
May 1, 2020
shiftkey
added a commit
that referenced
this pull request
May 2, 2020
shiftkey
added a commit
that referenced
this pull request
May 12, 2020
shiftkey
added a commit
that referenced
this pull request
May 12, 2020
shiftkey
added a commit
that referenced
this pull request
May 12, 2020
shiftkey
added a commit
that referenced
this pull request
May 16, 2020
shiftkey
added a commit
that referenced
this pull request
May 18, 2020
shiftkey
added a commit
that referenced
this pull request
May 22, 2020
shiftkey
added a commit
that referenced
this pull request
May 29, 2020
shiftkey
added a commit
that referenced
this pull request
Jul 3, 2020
shiftkey
added a commit
that referenced
this pull request
Jul 10, 2020
shiftkey
added a commit
that referenced
this pull request
Aug 19, 2020
shiftkey
added a commit
that referenced
this pull request
Aug 24, 2020
shiftkey
added a commit
that referenced
this pull request
Aug 27, 2020
shiftkey
added a commit
that referenced
this pull request
Aug 27, 2020
shiftkey
added a commit
that referenced
this pull request
Aug 27, 2020
shiftkey
added a commit
that referenced
this pull request
Nov 6, 2020
shiftkey
added a commit
that referenced
this pull request
Nov 6, 2020
shiftkey
added a commit
that referenced
this pull request
Nov 6, 2020
shiftkey
added a commit
that referenced
this pull request
Nov 6, 2020
shiftkey
added a commit
that referenced
this pull request
Nov 6, 2020
shiftkey
added a commit
that referenced
this pull request
Nov 6, 2020
shiftkey
added a commit
that referenced
this pull request
Nov 6, 2020
shiftkey
added a commit
that referenced
this pull request
Nov 6, 2020
shiftkey
added a commit
that referenced
this pull request
Nov 11, 2020
shiftkey
added a commit
that referenced
this pull request
Dec 11, 2020
shiftkey
added a commit
that referenced
this pull request
Dec 17, 2020
shiftkey
added a commit
that referenced
this pull request
Dec 17, 2020
shiftkey
added a commit
that referenced
this pull request
Dec 17, 2020
shiftkey
added a commit
that referenced
this pull request
Dec 17, 2020
shiftkey
added a commit
that referenced
this pull request
Dec 17, 2020
shiftkey
added a commit
that referenced
this pull request
Dec 18, 2020
shiftkey
added a commit
that referenced
this pull request
Dec 27, 2020
shiftkey
added a commit
that referenced
this pull request
Jan 23, 2021
shiftkey
added a commit
that referenced
this pull request
Jan 23, 2021
shiftkey
added a commit
that referenced
this pull request
Jan 24, 2021
shiftkey
added a commit
that referenced
this pull request
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partial fix for #222, but as we've uncovered in that issue the full fix requires:
sudo sysctl kernel.unprivileged_userns_clone=1to enable unprivileged user namespaces (specifically disabled in Debian and other distros), or--no-sandboxwhen launching the app (which effectively disables some of Chromium's security features)This change will be applied for both deb and rpm packages, but I think it's low risk. Will verify in a test at some stage.