[4.x] Improved Timezone Handling - #197
Merged
Merged
Conversation
jesseleite
added a commit
that referenced
this pull request
Jul 18, 2025
* Require statamic/cms dev-master for now We can change this to `^6.0` when an alpha/beta is tagged. * [4.x] Drop Laravel 10 Support (#200) * Remove Testbench 8 from composer.json * Remove PHPUnit 10 * Remove Laravel 10 and PHP 8.1 from testing matrix * Remove toStringFormat handling for Carbon 2 (#201) * [4.x] Improved Timezone Handling (#197) * Take the "display timezone" into account when setting Carbon string format * Use `Statamic::displayTimezone()` * Add config to enforce trailing slashes during generation. * Fix for 404 not generating. * Assemble absolute URL instead. * Fix `is404()` logic for hardcoded 404.html destination. * Handle config (tests still wip). * Add basic test coverage for generated URLs. * Add test coverage for our 404 fix. * Remove experimental note. We can just fix bugs as they're reported. * Temporary composer constraint until we tag Statamic v6. --------- Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>
duncanmcclean
added a commit
that referenced
this pull request
Sep 22, 2025
* Require statamic/cms dev-master for now We can change this to `^6.0` when an alpha/beta is tagged. * [4.x] Drop Laravel 10 Support (#200) * Remove Testbench 8 from composer.json * Remove PHPUnit 10 * Remove Laravel 10 and PHP 8.1 from testing matrix * Remove toStringFormat handling for Carbon 2 (#201) * [4.x] Improved Timezone Handling (#197) * Take the "display timezone" into account when setting Carbon string format * Use `Statamic::displayTimezone()` * Add config to enforce trailing slashes during generation. * Fix for 404 not generating. * Assemble absolute URL instead. * Fix `is404()` logic for hardcoded 404.html destination. * Handle config (tests still wip). * Add basic test coverage for generated URLs. * Add test coverage for our 404 fix. * Remove experimental note. We can just fix bugs as they're reported. * Temporary composer constraint until we tag Statamic v6. --------- Co-authored-by: Duncan McClean <duncan@duncanmcclean.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ensures that the new
display_timezoneconfig option is taken into account when the SSG sets Carbon'stoStringFormatsetting.Goes alongside statamic/cms#11409