fix: enforce S3 limits and reject negative/fractionals

[ferhatelmas]

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Part number caps or default didn't honor S3 expectations.
Validator is using number, not integer so it can accept floats.

What is the new behavior?

Align them with S3.
Change number type to integer where applicable.

Additional context

List objects has an old behavior to change 0 to 1000 but kept old behavior.
Get/Head object doesn't support part at the moment. Would be nice to add separately.

[Copilot]

Pull request overview

This PR aligns the S3-compatible API with S3 limits by defaulting/capping list-multipart-uploads behavior and tightening request validation to reject negative and fractional values (and enforce known S3 ranges for multipart part numbers and paging parameters).

Changes:

• Default ListMultipartUploads MaxUploads to 1000 and add a handler-level unit test for the default.
• Update S3 route JSON schemas from number to integer and add min/max bounds for multipart-related parameters.
• Add router validation tests covering integer-only constraints and S3 ranges across multipart/list operations.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/storage/protocols/s3/s3-handler.ts	Updates ListMultipartUploads default limit behavior.
src/storage/protocols/s3/s3-handler.test.ts	Adds coverage for the 1000 default behavior.
src/http/routes/s3/router.test.ts	Adds validation tests for integer-only and S3-range constraints.
src/http/routes/s3/commands/upload-part.ts	Enforces partNumber as integer within 1–10000.
src/http/routes/s3/commands/upload-part-copy.ts	Enforces partNumber as integer within 1–10000.
src/http/routes/s3/commands/list-parts.ts	Enforces max-parts as integer within 1–1000.
src/http/routes/s3/commands/list-objects.ts	Enforces max-keys as a non-negative integer.
src/http/routes/s3/commands/list-multipart-uploads.ts	Enforces max-uploads as integer within 1–1000.
src/http/routes/s3/commands/complete-multipart-upload.ts	Enforces completed part numbers within 1–10000.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coveralls]

Coverage Report for CI Build 29491592036

Coverage decreased (-0.1%) to 79.48%

Details

• Coverage decreased (-0.1%) from the base build.
• Patch coverage: 4 of 4 lines across 2 files are fully covered (100%).
• 20 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

20 previously-covered lines in 3 files lost coverage.

File	Lines Losing Coverage	Coverage
src/internal/http/agent.ts	17	32.56%
src/http/routes/s3/index.ts	2	82.99%
src/http/plugins/db.ts	1	82.47%

---

Coverage Stats

Relevant Lines:	12730
Covered Lines:	10565
Line Coverage:	82.99%
Relevant Branches:	7421
Covered Branches:	5451
Branch Coverage:	73.45%
Branches in Coverage %:	Yes
Coverage Strength:	425.28 hits per line

---

💛 - Coveralls

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.