fix: drop unused S3 logger middleware - #1249
Merged
Merged
Conversation
Coverage Report for CI Build 29824646150Coverage increased (+0.002%) to 79.591%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
There was a problem hiding this comment.
Beyond the flagged S3Store internal client gap, I checked the other two S3 client construction paths in this diff (S3Backend.createS3Client for the default and private-asset clients, and the shared S3Locker client in tus/index.ts) — both correctly call middlewareStack.remove('loggerMiddleware') right after construction, and the new adapter.test.ts case asserts this for both S3Backend clients. No other S3Client instantiations exist in the diff.
Extended reasoning...
Small, low-risk perf-only change (removes a middleware entry from AWS SDK clients); no security or correctness concerns beyond the inline nit already noted.
fenos
approved these changes
Jul 21, 2026
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
ferhat/drop-s3-logger-middleware
branch
from
July 21, 2026 11:03
e9f22a7 to
1593cbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Perf touch
What is the current behavior?
S3 logger isn't used so SDK uses no op logger which discards output line but it still runs a filter for sensitive data.
What is the new behavior?
No need to pay the price, disable it completely.