Skip to content

fix: drop unused S3 logger middleware - #1249

Merged
ferhatelmas merged 2 commits into
masterfrom
ferhat/drop-s3-logger-middleware
Jul 21, 2026
Merged

fix: drop unused S3 logger middleware#1249
ferhatelmas merged 2 commits into
masterfrom
ferhat/drop-s3-logger-middleware

Conversation

@ferhatelmas

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

Perf touch

What is the current behavior?

S3 logger isn't used so SDK uses no op logger which discards output line but it still runs a filter for sensitive data.

What is the new behavior?

No need to pay the price, disable it completely.

Copilot AI review requested due to automatic review settings July 20, 2026 22:45
@ferhatelmas
ferhatelmas requested a review from a team as a code owner July 20, 2026 22:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coveralls

coveralls commented Jul 20, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29824646150

Coverage increased (+0.002%) to 79.591%

Details

  • Coverage increased (+0.002%) from the base build.
  • Patch coverage: 9 of 9 lines across 3 files are fully covered (100%).
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
src/http/routes/s3/index.ts 1 82.99%

Coverage Stats

Coverage Status
Relevant Lines: 12764
Covered Lines: 10607
Line Coverage: 83.1%
Relevant Branches: 7448
Covered Branches: 5480
Branch Coverage: 73.58%
Branches in Coverage %: Yes
Coverage Strength: 426.41 hits per line

💛 - Coveralls

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the flagged S3Store internal client gap, I checked the other two S3 client construction paths in this diff (S3Backend.createS3Client for the default and private-asset clients, and the shared S3Locker client in tus/index.ts) — both correctly call middlewareStack.remove('loggerMiddleware') right after construction, and the new adapter.test.ts case asserts this for both S3Backend clients. No other S3Client instantiations exist in the diff.

Extended reasoning...

Small, low-risk perf-only change (removes a middleware entry from AWS SDK clients); no security or correctness concerns beyond the inline nit already noted.

Comment thread src/http/routes/tus/index.ts Outdated
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
@ferhatelmas
ferhatelmas force-pushed the ferhat/drop-s3-logger-middleware branch from e9f22a7 to 1593cbf Compare July 21, 2026 11:03
@ferhatelmas
ferhatelmas merged commit 97bc264 into master Jul 21, 2026
38 of 39 checks passed
@ferhatelmas
ferhatelmas deleted the ferhat/drop-s3-logger-middleware branch July 21, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants