Skip to content

Avoid repeated thread snapshot loads during subscription retries - #10

Open
tim-smart wants to merge 1 commit into
t3code/investigate-thread-resumefrom
t3code/diagnose-thread-polling-404
Open

Avoid repeated thread snapshot loads during subscription retries#10
tim-smart wants to merge 1 commit into
t3code/investigate-thread-resumefrom
t3code/diagnose-thread-polling-404

Conversation

@tim-smart

Copy link
Copy Markdown
Owner

Summary

  • Track whether the HTTP thread snapshot fallback has already been attempted.
  • Prevent socket subscription retries from repeatedly requesting a missing snapshot and producing recurring 404s.
  • Add coverage confirming subscriptions retry while the snapshot loader runs only once.

Testing

  • Added an Effect test that advances the retry clock and verifies the subscription count increases to two while the snapshot loader call count remains one.
  • Not run (test results were not provided).

@tim-smart
tim-smart force-pushed the t3code/diagnose-thread-polling-404 branch from 04c4fda to cf8453e Compare July 23, 2026 21:13
@tim-smart
tim-smart force-pushed the t3code/diagnose-thread-polling-404 branch from cf8453e to c41d76d Compare July 24, 2026 00:44
@tim-smart
tim-smart force-pushed the t3code/diagnose-thread-polling-404 branch 2 times, most recently from c72131d to ef19215 Compare July 24, 2026 03:34
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Jul 24, 2026
@tim-smart
tim-smart changed the base branch from main to t3code/investigate-thread-resume July 24, 2026 03:34
@tim-smart
tim-smart force-pushed the t3code/diagnose-thread-polling-404 branch from ef19215 to 0e66692 Compare July 24, 2026 08:52
@github-actions github-actions Bot added size:S and removed size:XXL labels Jul 24, 2026
@github-actions
github-actions Bot force-pushed the t3code/diagnose-thread-polling-404 branch from 0e66692 to ec48e06 Compare July 24, 2026 09:40
@github-actions
github-actions Bot force-pushed the t3code/diagnose-thread-polling-404 branch from ec48e06 to 4cadc27 Compare July 24, 2026 14:12
@tim-smart
tim-smart force-pushed the t3code/diagnose-thread-polling-404 branch from 4cadc27 to c8c9ead Compare July 25, 2026 10:26
@github-actions
github-actions Bot force-pushed the t3code/diagnose-thread-polling-404 branch 2 times, most recently from 8184888 to 674a1e6 Compare July 27, 2026 10:08
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 27, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 27, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.
@tim-smart
tim-smart force-pushed the t3code/diagnose-thread-polling-404 branch from 674a1e6 to c820c00 Compare July 28, 2026 00:30
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 28, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.
@tim-smart
tim-smart force-pushed the t3code/diagnose-thread-polling-404 branch from 17372cb to 3ec3189 Compare July 28, 2026 22:49
@tim-smart
tim-smart force-pushed the t3code/diagnose-thread-polling-404 branch from 3ec3189 to 97e1fee Compare July 28, 2026 22:54
@github-actions
github-actions Bot force-pushed the t3code/diagnose-thread-polling-404 branch from 97e1fee to 57e2c05 Compare July 29, 2026 03:38
@github-actions
github-actions Bot force-pushed the t3code/diagnose-thread-polling-404 branch from 57e2c05 to 31027de Compare July 29, 2026 09:08
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 29, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
@github-actions
github-actions Bot force-pushed the t3code/diagnose-thread-polling-404 branch from 31027de to 5359643 Compare July 29, 2026 11:45
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 29, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 30, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
- Attempt the HTTP snapshot fallback only once per thread state
- Cover socket retries after a missing snapshot
@tim-smart
tim-smart force-pushed the t3code/diagnose-thread-polling-404 branch from 5359643 to 2204859 Compare July 31, 2026 00:49
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 31, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 31, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 31, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 31, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 31, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 31, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 31, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 31, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Aug 4, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Aug 4, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Aug 5, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
patroza pushed a commit to patroza/t3code that referenced this pull request Aug 5, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
omegent-app Bot pushed a commit to patroza/t3code that referenced this pull request Aug 6, 2026
Avoid repeated thread snapshot loads during subscription retries

Source: tim-smart#10
Source head: c8c9ead
Source commits: c8c9ead
Imported: complete product delta from the source PR.

(cherry picked from commit 9e400c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant