Skip to content

Revert recent checksum CLI changes - #10141

Merged
sylvestre merged 7 commits into
uutils:mainfrom
RenjiSann:revert-checksum-clap
Jan 10, 2026
Merged

Revert recent checksum CLI changes#10141
sylvestre merged 7 commits into
uutils:mainfrom
RenjiSann:revert-checksum-clap

Conversation

@RenjiSann

Copy link
Copy Markdown
Collaborator

This PR reverts several changes that transitioned manual CLI argument parsing, at the expense of error messages explicitness and GNU behavior soundness.

This is preparatory work for cksum/hashsum merging, which will greatly simplify the maintenance of checksum-related utils

@RenjiSann
RenjiSann requested a review from sylvestre January 9, 2026 12:26
@sylvestre

Copy link
Copy Markdown
Contributor

some jobs are failing

@oech3

oech3 commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

No need to revert everything. --warn,etc... without --check only.
We can just backport GNU master's error handlings #10131

@RenjiSann
RenjiSann force-pushed the revert-checksum-clap branch from c9010ee to b1edc49 Compare January 9, 2026 12:48
@RenjiSann

Copy link
Copy Markdown
Collaborator Author

No need to revert everything. --warn,etc... without --check only. We can just backport GNU master's error handlings #10131

I'm sorry it looks a bit severe, but I'm having a hard time making the difference between everything, partly because I wasn't following along in the last two weeks.

I admit that this may not be the most optimal solution, but I really want to be done with getting rid of hashsum and code duplication already, so I'd rather revert too many things now and then reconsider all these changes once we have a common base to work on for all tools.

@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@oech3

oech3 commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

OK. I made every my *sum PR to draft. Let delete hashsum anyway.

@sylvestre
sylvestre merged commit 6a20bcb into uutils:main Jan 10, 2026
134 checks passed
@RenjiSann
RenjiSann deleted the revert-checksum-clap branch January 24, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants