Skip to content

cp: handle special files - #11163

Merged
sylvestre merged 1 commit into
uutils:mainfrom
victor-prokhorov:fix-device-nodes-as-streams
Mar 4, 2026
Merged

cp: handle special files#11163
sylvestre merged 1 commit into
uutils:mainfrom
victor-prokhorov:fix-device-nodes-as-streams

Conversation

@victor-prokhorov

@victor-prokhorov victor-prokhorov commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

fixes #9746, fixes #8679, fixes #9433

addressed the comment suggesting refactoring parameters

@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/rm/isatty. tests/rm/isatty is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Congrats! The gnu test tests/tail/retry is no longer failing!

@victor-prokhorov
victor-prokhorov force-pushed the fix-device-nodes-as-streams branch from 951dc1e to 7300552 Compare March 1, 2026 08:58
@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Congrats! The gnu test tests/tail/retry is no longer failing!
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.

@codspeed-hq

codspeed-hq Bot commented Mar 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 294 untouched benchmarks
⏩ 42 skipped benchmarks1


Comparing victor-prokhorov:fix-device-nodes-as-streams (758219c) with main (ba94c69)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@victor-prokhorov
victor-prokhorov force-pushed the fix-device-nodes-as-streams branch from 7300552 to bb23f94 Compare March 1, 2026 12:23
@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/isatty is no longer failing!
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.

@victor-prokhorov
victor-prokhorov force-pushed the fix-device-nodes-as-streams branch from bb23f94 to e2a0f50 Compare March 1, 2026 12:57
@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/isatty is no longer failing!
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@victor-prokhorov
victor-prokhorov force-pushed the fix-device-nodes-as-streams branch from e2a0f50 to 64ed6a4 Compare March 1, 2026 13:35
@victor-prokhorov
victor-prokhorov force-pushed the fix-device-nodes-as-streams branch from 64ed6a4 to 758219c Compare March 1, 2026 13:52
@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/isatty is no longer failing!

@victor-prokhorov
victor-prokhorov marked this pull request as ready for review March 1, 2026 21:20
@sylvestre
sylvestre merged commit e6a3bb5 into uutils:main Mar 4, 2026
160 checks passed
@sylvestre

Copy link
Copy Markdown
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cp -R reads device nodes as streams instead of recreating them cp: cp -a /dev/null creates empty file cp -r /dev/urandom copies content

2 participants