chown: -h on symlink to directory operates on link, not target - #12522
Merged
Conversation
|
GNU testsuite comparison: |
Contributor
|
some jobs are failing |
rossilor95
force-pushed
the
chown-fix-h-symlink-to-dir
branch
from
May 30, 2026 09:02
d94fc78 to
d1d887e
Compare
Contributor
Author
I solved the style issue (my bad, forgot to run cargo fmt before committing 😅). About |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11887
chown -hon a symlink-to-directory chowned the target instead of the link. The Linux fast path usedPath::is_dir(), which resolves symlinks and routed the call into the directory-traversal branch.Switch to
Metadata::is_dir()on the already-lstat'd metadata so the--no-dereferencecontract is preserved. Added regression testtest_chown_no_dereference_symlink_to_dirthat creates a symlink to a directory, runschown --no-dereference, and asserts viactimethat the syscall touched the symlink's inode (link's ctime advances) and not the target's (directory's ctime is unchanged). Confirmed the test fails on the unfixed code and passes with the fix.Repro (from #11887)