Skip to content

od: skip past end of seekable inputs without error - #12646

Merged
sylvestre merged 5 commits into
uutils:mainfrom
sylvestre:od-skip-seekable
Aug 2, 2026
Merged

od: skip past end of seekable inputs without error #12646
sylvestre merged 5 commits into
uutils:mainfrom
sylvestre:od-skip-seekable

Conversation

@sylvestre

@sylvestre sylvestre commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

fixes: tests/od/od-j

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/od/od-j is no longer failing!
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@cakebaker

Copy link
Copy Markdown
Contributor

One of the new tests fails on WASI with:

run: /home/runner/work/coreutils/coreutils/target/wasm32-wasip1/debug/coreutils.wasm od -j1 /dev/null

thread 'test_od::test_skip_bytes_past_end_of_seekable_device' (28790) panicked at tests/by-util/test_od.rs:945:10:
Command was expected to succeed. code: 1
stdout = 
 stderr = od: /dev/null: No such file or directory
od: tried to skip past end of input

/dev/null isn't backed by a real seekable device in the WASI sandbox via
wasmtime, so the skip-past-end behavior this test checks doesn't apply
there -- matches the existing convention for other WASI-incompatible
tests in this file.
@oech3

oech3 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

is this ready to merge?

@sylvestre

Copy link
Copy Markdown
Contributor Author

yeah, thanks

@sylvestre
sylvestre merged commit 7a9d37e into uutils:main Aug 2, 2026
175 of 177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants