ls: use Unicode quotes for locale/clocale styles in UTF-8 locales - #12675
Merged
Conversation
65 tasks
sylvestre
force-pushed
the
ls-locale-quoting-utf8
branch
3 times, most recently
from
June 7, 2026 19:55
5a33477 to
6793424
Compare
The locale and clocale quoting styles always emitted ASCII quotes and escaped embedded apostrophes/double quotes, regardless of the locale. GNU uses Unicode quotation marks U+2018/U+2019 (keyed off LC_CTYPE) for both styles in a UTF-8 locale, leaving embedded ASCII quotes untouched. Should make test tests/ls/quoting-utf8.sh pass.
sylvestre
force-pushed
the
ls-locale-quoting-utf8
branch
from
June 18, 2026 06:24
6793424 to
934f8fc
Compare
|
GNU testsuite comparison: |
Contributor
Author
|
simple enough, auto merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The locale and clocale quoting styles always emitted ASCII quotes and escaped embedded apostrophes/double quotes, regardless of the locale. GNU uses Unicode quotation marks U+2018/U+2019 (keyed off LC_CTYPE) for both styles in a UTF-8 locale, leaving embedded ASCII quotes untouched.
Should make test tests/ls/quoting-utf8.sh pass.