Skip to content

df: Syncing when paths are provided - #12707

Merged
sylvestre merged 2 commits into
uutils:mainfrom
max-amb:fix_df_sync
Jun 8, 2026
Merged

df: Syncing when paths are provided#12707
sylvestre merged 2 commits into
uutils:mainfrom
max-amb:fix_df_sync

Conversation

@max-amb

@max-amb max-amb commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Part of #12584, fixing df/sync.sh.

Decided not to use syncfs for when filesystems are provided (which would only sync the required filesystems), though I am very open to this being the desired implementation. It isn't clear to me why the sync call was initially left out of the case where paths are provided, but might have missed something...

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/df/sync is no longer failing!
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@sylvestre

Copy link
Copy Markdown
Contributor

Congrats! The gnu test tests/df/sync is no longer failing!

sweet!

@sylvestre
sylvestre merged commit 4a41104 into uutils:main Jun 8, 2026
173 of 175 checks passed
@max-amb
max-amb deleted the fix_df_sync branch June 8, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants