Skip to content

Fix base32/base64 error for file paths ending in slash - #12726

Merged
RenjiSann merged 1 commit into
uutils:mainfrom
TheAdamWarlock:fix-base-common-path-errors
Jun 11, 2026
Merged

Fix base32/base64 error for file paths ending in slash#12726
RenjiSann merged 1 commit into
uutils:mainfrom
TheAdamWarlock:fix-base-common-path-errors

Conversation

@TheAdamWarlock

Copy link
Copy Markdown
Contributor

Fixes #12670

Before, base32 and base64 checked Path::exists() before opening the file. That turned the real OS error into No such file or directory. Now the file is opened directly, so paths like file/ correctly report Not a directory.

Added regression tests for base32 and base64.

No GNU coreutils source code was read or copied.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.

@RenjiSann
RenjiSann merged commit c77bf21 into uutils:main Jun 11, 2026
174 of 175 checks passed
@RenjiSann

Copy link
Copy Markdown
Collaborator

Thanks !

@TheAdamWarlock
TheAdamWarlock deleted the fix-base-common-path-errors branch June 20, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: base32 and base64 incorrect error messages when appending to a regular file /

2 participants