Skip to content

touch: do not hang on a reader-less FIFO - #12735

Merged
cakebaker merged 3 commits into
uutils:mainfrom
sylvestre:fifo2
Jun 15, 2026
Merged

touch: do not hang on a reader-less FIFO#12735
cakebaker merged 3 commits into
uutils:mainfrom
sylvestre:fifo2

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

Should make test touch/fifo.sh pass

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tty-eof (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/touch/empty-file is no longer failing!
Congrats! The gnu test tests/touch/fifo is no longer failing!
Congrats! The gnu test tests/touch/no-rights is no longer failing!
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/expand/bounded-memory is now passing!
Congrats! The gnu test tests/pr/bounded-memory is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@RenjiSann

Copy link
Copy Markdown
Collaborator

doesn't compile on redox

Should make test touch/fifo.sh pass
Should make test touch/empty-file.sh pass
rustix does not expose utimensat/AtFlags on the redox target, so the
cfg(unix) path failed to compile. Add a redox-specific set_times_by_path
that falls back to filetime::set_file_times.
@cakebaker
cakebaker merged commit 1b912dc into uutils:main Jun 15, 2026
174 of 175 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Congrats! The gnu test tests/touch/empty-file is no longer failing!
Congrats! The gnu test tests/touch/fifo is no longer failing!
Congrats! The gnu test tests/touch/no-rights is no longer failing!

Great, kudos!

@sylvestre
sylvestre deleted the fifo2 branch June 16, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants