Skip to content

cp: don't open FIFOs/devices when preserving timestamps - #13351

Merged
sylvestre merged 3 commits into
uutils:mainfrom
sylvestre:cp-preserve-mode
Jul 22, 2026
Merged

cp: don't open FIFOs/devices when preserving timestamps#13351
sylvestre merged 3 commits into
uutils:mainfrom
sylvestre:cp-preserve-mode

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

set_file_times opens the destination before calling futimens; opening a FIFO with no writer blocks forever. Use the path-based utimensat variant for symlinks and other non-regular files.

Should make test tests/cp/preserve-mode.sh pass

set_file_times opens the destination before calling futimens; opening a
FIFO with no writer blocks forever. Use the path-based utimensat variant
for symlinks and other non-regular files.

Should make test tests/cp/preserve-mode.sh pass
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cp/preserve-mode is no longer failing!
Congrats! The gnu test tests/misc/selinux is no longer failing!
Congrats! The gnu test tests/expand/bounded-memory is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@codspeed-hq

codspeed-hq Bot commented Jul 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 339 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing sylvestre:cp-preserve-mode (accfde5) with main (ef50d8b)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre

Copy link
Copy Markdown
Contributor Author

Congrats! The gnu test tests/cp/preserve-mode is no longer failing!

!
automerge then

@sylvestre
sylvestre merged commit 5400500 into uutils:main Jul 22, 2026
164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant