shred: report the real error for an inaccessible file - #13640
Merged
Conversation
shred used Path::exists() and Path::is_file() to pre-check the target, but both return false on any metadata error, so a file whose parent directory lacks search permission was reported as "No such file or directory". Inspect the metadata directly so a genuine ENOENT stays a not-found error while a permission error falls through to the open-for-writing path, which surfaces the real reason.
Merging this PR will improve performance by 24.47%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | df_with_path |
305.3 µs | 245.3 µs | +24.47% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing 0xfandom:shred-inaccessible-real-error (8b695ce) with main (197eac4)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13639.
shred's pre-checks usedPath::exists()andPath::is_file(), both of which returnfalsefor any metadata access error, including a permission error. As a result, a file whose parent directory lacks search permission was reported as:even though it exists.
This replaces the two checks with a single
fs::metadata()match:ENOENTstill yields "No such file or directory";All the normal cases (missing file, dangling symlink, directory, regular file) keep their existing behaviour. Added a
#[cfg(unix)]regression test that shreds a file inside a0o000directory and asserts the error mentions "Permission denied" and not "No such file"; it fails on the oldPath::exists()code and passes with the fix. This mirrors the fix in #9789 (chmod).