join: add support for non-unicode field separators - #2902
Merged
Conversation
sylvestre
reviewed
Jan 30, 2022
Contributor
There was a problem hiding this comment.
it would be nice to update the test on non unix to verify that the error is here :)
Contributor
Author
There was a problem hiding this comment.
Rebased and pushed with a new test. We have to use Windows for our non-unix, since that's the only other OS that gives any sort of access to the internal OsString representation.
jtracey
force-pushed
the
join-non-unicode-sep
branch
4 times, most recently
from
January 30, 2022 23:41
984a5ba to
04e5538
Compare
This allows for `-t` to take invalid unicode (but still single-byte) values on unix-like platforms. Other platforms, which as of the time of this commit do not support `OsStr::as_bytes()`, could possibly be supported in the future, but would require design decisions as to what that means.
jtracey
force-pushed
the
join-non-unicode-sep
branch
from
January 31, 2022 01:04
04e5538 to
58d65fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for
-tto take invalid unicode (but still single-byte) valueson unix-like platforms. Other platforms, which as of the time of this commit
do not support
OsStr::as_bytes(), could possibly be supported in the future,but would require design decisions as to what that means.
See the section on conversions in the ffi Rust docs for more detail on what is currently exposed.
Lets the 8-bit-t GNU test pass (see #2634).