Skip to content

du: directories have apparent size of 0 - #4991

Merged
cakebaker merged 1 commit into
uutils:mainfrom
shinhs0506:du_apparent
Jun 26, 2023
Merged

du: directories have apparent size of 0#4991
cakebaker merged 1 commit into
uutils:mainfrom
shinhs0506:du_apparent

Conversation

@shinhs0506

Copy link
Copy Markdown
Contributor

No description provided.

@shinhs0506
shinhs0506 force-pushed the du_apparent branch 2 times, most recently from de8caaa to e47fc34 Compare June 20, 2023 19:54
@github-actions

github-actions Bot commented Jun 20, 2023

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!

@github-actions

github-actions Bot commented Jun 20, 2023

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!

@shinhs0506
shinhs0506 marked this pull request as ready for review June 20, 2023 21:34
Comment thread tests/by-util/test_du.rs Outdated
Comment thread tests/by-util/test_du.rs Outdated
Comment thread tests/by-util/test_du.rs Outdated
Comment thread tests/by-util/test_du.rs Outdated
@cakebaker

cakebaker commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

When I run the updated tests, without applying the changes to du.rs, all tests pass. Is that intentional?

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!
Skipping an intermittent issue tests/tail-2/inotify-dir-recreate

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/du/apparent is no longer failing!

@shinhs0506

Copy link
Copy Markdown
Contributor Author

@cakebaker everything resolved, thanks :)

@cakebaker
cakebaker merged commit 9149409 into uutils:main Jun 26, 2023
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks! Good idea of introducing stdout_contains_line, it's a much cleaner solution than what I suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants