Skip to content

kill: print signals vertically when using --list flag - #6201

Merged
BenWiederhake merged 2 commits into
uutils:mainfrom
m-haisham:main
Apr 7, 2024
Merged

kill: print signals vertically when using --list flag#6201
BenWiederhake merged 2 commits into
uutils:mainfrom
m-haisham:main

Conversation

@m-haisham

Copy link
Copy Markdown
Contributor

Environment: Ubuntu 20.04, uutils main branch (git commit 415de28), GNU coreutils version 9.5.3-8f39 (from git commit coreutils/coreutils@8f3989d).

See #6197 for more details.

@BenWiederhake BenWiederhake left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah! Short and sweet :D

@github-actions

github-actions Bot commented Apr 7, 2024

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/misc/kill. tests/misc/kill is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/kill is no longer ERROR!
GNU test failed: tests/cp/cross-dev-symlink. tests/cp/cross-dev-symlink is passing on 'main'. Maybe you have to rebase?

@m-haisham
m-haisham force-pushed the main branch 2 times, most recently from 697d85d to 0bc6d16 Compare April 7, 2024 17:57
@m-haisham

Copy link
Copy Markdown
Contributor Author

Accidentally pushed table formatting code to this branch, I've rolled it back.

@BenWiederhake BenWiederhake left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@m-haisham

Copy link
Copy Markdown
Contributor Author

Failed check does not seem to be related to this tool. @BenWiederhake

@BenWiederhake
BenWiederhake merged commit 843407f into uutils:main Apr 7, 2024
@BenWiederhake

Copy link
Copy Markdown
Collaborator

Thank you!

@sylvestre

Copy link
Copy Markdown
Contributor

it would have been nice to have a test to make sure we don't regress in the future

@BenWiederhake

Copy link
Copy Markdown
Collaborator

You're right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants