Skip to content

kill: accept all cases for signal names - #6229

Merged
BenWiederhake merged 2 commits into
uutils:mainfrom
m-haisham:main
Apr 15, 2024
Merged

kill: accept all cases for signal names#6229
BenWiederhake merged 2 commits into
uutils:mainfrom
m-haisham:main

Conversation

@m-haisham

Copy link
Copy Markdown
Contributor

This PR updates the signal name comparison to work with all cases. The changes are effective on --list and --signal commands.

$ cargo run --features kill kill -l sIgUsR2
12
[$? = 1]
$ kill -l sIgUsR2 # bash built-in
12
$ /usr/bin/kill -l sIgUsR2 # Debian procps-ng 4.0.4
12

Fixes #6217

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

@BenWiederhake BenWiederhake left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does exactly what it says on the tin, and thorough tests. Thank you! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kill: signal names only understood in uppercase, should accept all casings

2 participants