Skip to content

tests/install/install-Z-selinux: fix selinux for install - #8307

Merged
cakebaker merged 1 commit into
uutils:mainfrom
sylvestre:install-selinux
Oct 22, 2025
Merged

tests/install/install-Z-selinux: fix selinux for install#8307
cakebaker merged 1 commit into
uutils:mainfrom
sylvestre:install-selinux

Conversation

@sylvestre

@sylvestre sylvestre commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions

github-actions Bot commented Jul 12, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions

github-actions Bot commented Jul 14, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions

github-actions Bot commented Jul 15, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions

github-actions Bot commented Jul 16, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions

github-actions Bot commented Jul 16, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre
sylvestre marked this pull request as ready for review July 25, 2025 14:28
@sylvestre
sylvestre requested a review from cakebaker July 25, 2025 14:28
@sylvestre sylvestre changed the title Install selinux tests/install/install-Z-selinux: fix selinux Jul 25, 2025
@sylvestre sylvestre changed the title tests/install/install-Z-selinux: fix selinux tests/install/install-Z-selinux: fix selinux for install Jul 25, 2025
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
Comment thread src/uucore/src/lib/features/selinux.rs Outdated
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
Comment thread src/uucore/src/lib/features/selinux.rs Outdated
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
Comment thread src/uucore/src/lib/features/selinux.rs Outdated
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
Comment thread src/uucore/src/lib/features/selinux.rs Outdated
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
Comment thread src/uucore/src/lib/features/selinux.rs Outdated
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
Comment thread src/uucore/src/lib/features/selinux.rs Outdated
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
Comment thread src/uucore/src/lib/features/selinux.rs Outdated
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
Comment thread src/uucore/src/lib/features/selinux.rs Outdated
@github-actions

github-actions Bot commented Jul 27, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre
sylvestre force-pushed the install-selinux branch 3 times, most recently from b268db4 to 8e81ec6 Compare July 27, 2025 19:39
@github-actions

github-actions Bot commented Jul 27, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre
sylvestre requested a review from cakebaker July 28, 2025 05:34
cakebaker
cakebaker reviewed Jul 28, 2025
View reviewed changes
Comment thread src/uu/install/src/install.rs Outdated
/// # Returns
///
/// Returns `Ok(())` if the context was successfully set, or a `SeLinuxError` if the operation failed.
pub fn set_selinux_default_context_for_install(path: &Path) -> Result<(), SeLinuxError> {

@cakebaker cakebaker Jul 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would shorten the name to just set_selinux_default_context.

cakebaker
cakebaker reviewed Jul 28, 2025
View reviewed changes
Comment thread src/uu/install/src/install.rs
@github-actions

github-actions Bot commented Sep 11, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions

github-actions Bot commented Sep 11, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre
sylvestre force-pushed the install-selinux branch 2 times, most recently from 82878ae to cc8ee03 Compare September 11, 2025 22:04
@github-actions

github-actions Bot commented Sep 11, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre
sylvestre requested a review from cakebaker September 12, 2025 06:27
@cakebaker

cakebaker commented Sep 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

The update of ctrlc to 3.5.0 doesn't work on Redox, so I would downgrade it to the previous version. The PR also contains an unrelated commit.

@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre
Install: implement -Z
2434c2a 
Fixes: tests/install/install-Z-selinux
@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@cakebaker
cakebaker merged commit 8d891bb into uutils:main Oct 22, 2025
122 checks passed
@cakebaker

cakebaker commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

Great, kudos :)

@sylvestre
sylvestre deleted the install-selinux branch October 22, 2025 15:56
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylvestre @cakebaker