Add GitHub as valid CI for plugin and theme scaffold#331
Merged
danielbachhuber merged 2 commits intowp-cli:mainfrom Apr 12, 2024
ernilambar:feature-github-support
Merged
Add GitHub as valid CI for plugin and theme scaffold#331danielbachhuber merged 2 commits intowp-cli:mainfrom ernilambar:feature-github-support
danielbachhuber merged 2 commits intowp-cli:mainfrom
ernilambar:feature-github-support
Conversation
Member
Can you test? |
Member
Author
|
@danielbachhuber I created sample theme and removed that conditional checks. All tests have run successfully. ernilambar/sample-theme#3 Sample plugin check: https://github.com/ernilambar/sample-plugin/pull/3 |
Member
Author
|
@danielbachhuber It looks ok for me to remove following code from Should it be done in separate PR? |
Member
|
Separate PR sounds good |
danielbachhuber
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #330
githubas valid option for--ciargument.github/workflows/testing.ymlNote:
For theme, in
theme-bootstrap.muscatche, there is code for checking PHP version. So test is exited for PHP greater than 8.0. Is this still valid?