Fix tests after change in WordPress trunk#195
Merged
swissspidy merged 2 commits intomainfrom May 7, 2024
Merged
Conversation
Member
|
Are these failing tests related to these changes? |
Member
Author
|
Ah yes, looks like I need to fix the following assertions as well. |
Member
Author
|
@thelovekesh should be fixed now |
thelovekesh
approved these changes
May 7, 2024
Member
|
It seems like the requests library is not PHP 8.4 compatible. We can probably ignore those failing tests for now. |
Member
Author
|
@thelovekesh Please see wp-cli/wp-cli#5946 PHP 8.4 is in alpha anyway and all 8.4 tests are marked as allowed to fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the test case after https://core.trac.wordpress.org/changeset/58105 to address failures.
Simply removes the bits with the autoload value from the assertions.
The alternative would be to use a different value depending on the WP version but that seems overkill.