Merged
Conversation
`siteurl` is not necessarily the first row in `wp_options`. It appears that other options such as `cron` can be first. This removes the option ID from the assertion, as it is not relevant. We only want to verify that the site URL changed.
ernilambar
approved these changes
Jun 28, 2024
Member
Any idea which recent core changeset made changes regarding this? |
Member
Author
|
Not really. Maybe one of the autoload-related changes 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
siteurlis not necessarily the first row inwp_options.It appears that other options such as
croncan be first.This removes the option ID from the assertion, as it is not relevant.
We only want to verify that the site URL changed.