[LWG 6] P2164R9 views::enumerate #6135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burblebee
force-pushed
the
motions-2023-02-lwg-6
branch
2 times, most recently
from
8c472f4 to
2ded891
Compare
JohelEGP
suggested changes
Feb 21, 2023
JohelEGP
approved these changes
Feb 23, 2023
hewillk
reviewed
Feb 23, 2023
Contributor
|
I did these reviews a week ago, but I didn't realize until now that all my reviews are in PENDING status, which means my reviews haven't been submitted. lol. |
tkoeppe
force-pushed
the
motions-2023-02-lwg-6
branch
3 times, most recently
from
66b3e76 to
347232d
Compare
Editorial changes: * Added missing "views::" qualification in example * Added missing "friend" in itemdecls * Fixed "pos_" to "i.pos_" in iter_move definition * Removed erroneous and unused default argument "pos = 0" Fixes NB FR 021, US 108 (C++23 CD).
The comment was attached to the line of the definition of sentinel's class, but it should appear on the line of the declaration of its first constructor.
tkoeppe
force-pushed
the
motions-2023-02-lwg-6
branch
from
347232d to
1ed375a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NB FR 14-021, US 48-108 (C++23 CD).
Fixes #6096.
Fixes cplusplus/papers#875
Fixes cplusplus/nbballot#525
Fixes cplusplus/nbballot#416