This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix missing drop indicator on Electron >= 1.14 #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The security model of new Chromium versions forbids all event listeners, except for `onDragStart` and `onDrop`, to inspect the data values that have been previously set on the event's `dataTransfer` object. To circumvent this problem we can exploit the fact that all we need to do is checking whether a boolean has been set or not. To do so, we will simply list all the items contained in the `dataTransfer` object and read their `kind` property (that we use as a dictionary key), verifying that at least one of them contains the key we are searching for.
as-cii
force-pushed
the
as-fix-missing-drop-indicator
branch
from
4812bb9 to
c3725a6
Compare
17 tasks
60 tasks
59 tasks
8 tasks
7 tasks
76 tasks
58 tasks
64 tasks
64 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security model of new Chromium versions forbids all event listeners, except for
onDragStartandonDrop, to inspect the data values that have been previously set on the event'sdataTransferobject.To circumvent this problem we can exploit the fact that all we need to do is checking whether a boolean has been set or not. To do so, we will simply list all the items contained in the
dataTransferobject and read theirtypeproperty (that we use as a dictionary key), verifying that at least one of them contains the key we are searching for.Before:
After:
/cc: @atom/maintainers