Prevent space leaks in zip family, mapAccum{L,R}
#3039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanG077
reviewed
Oct 10, 2025
christiaanb
approved these changes
Oct 16, 2025
In the multi-map implementation, each part of the tuple will reference the original input if left unevaluated. In case of `Signal`s, this can cause the complete simulation to build up in memory. Fixes #3038
martijnbastiaan
force-pushed
the
martijn/prevent-space-leak-zip
branch
from
4853b1e to
617441a
Compare
2 tasks
martijnbastiaan
added a commit
that referenced
this pull request
Oct 16, 2025
Prevent space leaks in `zip` family, `mapAccum{L,R}` (copy #3039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3038
Still TODO:
Check copyright notices are up to date in edited files