Add code cleanup rules (+perf) #44269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Sep 30, 2022
| { | ||
| return _services.GetRequiredService<DfaMatcherBuilder>(); | ||
| }); | ||
| return new DataSourceDependentMatcher(dataSource, lifetime, _services.GetRequiredService<DfaMatcherBuilder>); |
Member
Author
There was a problem hiding this comment.
Yeah, it's _services.GetRequiredService<DfaMatcherBuilder> not _services.GetRequiredService<DfaMatcherBuilder>(). (note the missing parens)
BrennanConroy
requested review from
a team,
JamesNK,
Tratcher,
halter73 and
javiercn
as code owners
Tratcher
approved these changes
Oct 3, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDE0020: Use pattern matching to avoid is check followed by a cast (with variable)
IDE0029: Use coalesce expression (non-nullable types)
IDE0030: Use coalesce expression (nullable types)
IDE0031: Use null propagation
IDE0038: Use pattern matching to avoid is check followed by a cast (without variable)
IDE0200: Lambda expression can be removed
These rules all can result in improved performance, details explained in https://devblogs.microsoft.com/dotnet/performance_improvements_in_net_7/
Additionally, it's often cleaner looking code.