Enable CA1854 #44799
Merged
Enable CA1854 #44799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Thanks for your PR, @martincostello. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Fix CA1854 analyser warnings.
martincostello
force-pushed
the
enable-ca1854
branch
from
bb14b9d to
bc2a942
Compare
Fix additional CA1854 warnings.
Fix an additional CA1854 warning.
martincostello
requested review from
a team,
BrennanConroy,
JamesNK,
Tratcher,
captainsafia and
halter73
as code owners
Tratcher
approved these changes
Oct 31, 2022
JamesNK
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable CA1854
Enable CA1854 to prefer
IDictionary.TryGetValue().Description
Enables the new CA1854 analyser.
See #44791 (comment).
Will see what CI throws up, and then look at how many get flushed out to be fixed.
/cc @BrennanConroy