Skip to content

Add CancellationToken.Register with callback accepting token #43114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 2 commits into from
Oct 9, 2020
Merged

Add CancellationToken.Register with callback accepting token #43114

stephentoub merged 2 commits into from
Oct 9, 2020

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Oct 6, 2020

@Dotnet-GitSync-Bot
Copy link
Collaborator

Dotnet-GitSync-Bot commented Oct 6, 2020

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

geoffkizer
geoffkizer approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@geoffkizer geoffkizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small issues above. Generally LGTM.

@davidfowl
Copy link
Member

davidfowl commented Oct 7, 2020

Now we just need the async version 😬

@ghost
Copy link

ghost commented Oct 7, 2020

Tagging subscribers to this area: @tarekgh
See info in area-owners.md if you want to be subscribed.

@runfoapp runfoapp bot mentioned this pull request Oct 8, 2020
Closed
@stephentoub stephentoub merged commit 1202565 into dotnet:master Oct 9, 2020
@stephentoub stephentoub deleted the registertoken branch October 9, 2020 01:57
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekgh tarekgh tarekgh approved these changes

+1 more reviewer

@geoffkizer geoffkizer geoffkizer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Threading.Tasks new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: Add overloads for CancellationToken.[Unsafe]Register that pass the CancellationToken to the registered function

5 participants

@stephentoub @Dotnet-GitSync-Bot @davidfowl @tarekgh @geoffkizer