Use function pointers in OSX FileSystemWatcher #52090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @carlossanlop Issue Details
|
jkotas
commented
Apr 30, 2021
| private readonly FSEventStreamEventFlags _filterFlags; | ||
|
|
||
| // Callback delegate for the EventStream events | ||
| private readonly Interop.EventStream.FSEventStreamCallback _callback; |
Member
Author
There was a problem hiding this comment.
Avoids the delegate allocation and indirection.
jkotas
commented
Apr 30, 2021
| public IntPtr RetainFunc; | ||
| public IntPtr ReleaseFunc; | ||
| public CFStringRef CopyDescriptionFunc; | ||
| public IntPtr info; |
Member
Author
There was a problem hiding this comment.
Fixed this structure to follow interop coding conventions (use the same name and casing as the Apple SDK definition).
adamsitnik
approved these changes
Apr 30, 2021
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you for adding all the comments 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.