Remove some overhead from XmlNode.SelectSingleNode #54299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently implemented by delegating to SelectSingleNodes and returning the first one. While the list is lazily-populated, this still entails creating an `XPathNodeList`, creating a `List<XmlNode>`, storing the enumerated into the list, and then returning the element from the list, which is then thrown away. With just a few lines, we can cut through all of that.
No need for these to be allocated classes. They can just live on the stack where they're created.
This shows up on the hot path of parsing the xpath expression. We can use a span to avoid bounds checking.
NextChar is used by lots of routines to advance to the next character. We can streamline it to avoid the bounds check when indexing into the string.
The typical case is there isn't any whitespace, so inline that fast check. This was showing up as a few percentage of a simple scenario.
ghost
added
the
|
Tagging subscribers to this area: @buyaa-n, @krwq Issue DetailsUsing the example from https://docs.microsoft.com/en-us/dotnet/api/system.xml.xmlnode.selectsinglenode?view=net-5.0#System_Xml_XmlNode_SelectSingleNode_System_String_ :
|
buyaa-n
reviewed
Jun 17, 2021
src/libraries/System.Private.Xml/src/System/Xml/XPath/Internal/XPathScanner.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 17, 2021
src/libraries/System.Private.Xml/src/System/Xml/XPath/Internal/XPathScanner.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 17, 2021
src/libraries/System.Private.Xml/src/System/Xml/XPath/Internal/XPathScanner.cs
Show resolved
Hide resolved
krwq
approved these changes
Jun 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the example from https://docs.microsoft.com/en-us/dotnet/api/system.xml.xmlnode.selectsinglenode?view=net-5.0#System_Xml_XmlNode_SelectSingleNode_System_String_ :