Optimize TimeSpan.FromX for constant input #55745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
approved these changes
Jul 15, 2021
Member
Author
|
@dotnet/jit-contrib PTAL at the change in importer.cpp |
AndyAyersMS
reviewed
Jul 16, 2021
src/coreclr/jit/importer.cpp
Outdated
| actualArg = gtFoldExprConst(actualArg); | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Any reason we can't just call gtFoldExpr(actualArg) and catch some of the other cases where we can fold?
If you still want to case it out like this, I don't think any of these != nullptr checks are needed.
Member
Author
There was a problem hiding this comment.
there was some assert that checked actualArg's type against sigType. E.g. it failed for int -> ubyte (after gtFoldExpr)
* ADD int
+--* CNS_INT int 0
\--* FIELD ubyte hackishFieldName
\--* LCL_VAR ref V00 this
after gtFoldExpr:
* FIELD ubyte hackishFieldName
\--* LCL_VAR ref V00 this
I removed the assert and it seems work fine.
If you still want to case it out like this, I don't think any of these != nullptr checks are needed.
E.g. GT_HWINTRINSIC (Vector_get_Zero) is a binary node with both children nullptr (IsBinary returns true)
Member
|
Also the |
Member
Author
Ah, right, I've just updated the diffs, these use correct baseline. |
Member
Author
|
@dotnet/jit-contrib @AndyAyersMS PTAL |
Member
|
@dotnet/jit-contrib just going through old PR's that were already signed off and noticed this might possibly only need one review to merge. |
marek-safar
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsJust a small change to optimize TimeSpan Test() => TimeSpan.FromSeconds(5);Was: ; Method Program:Test():System.TimeSpan:this
4883EC28 sub rsp, 40
C5F877 vzeroupper
C5FB100511000000 vmovsd xmm0, qword ptr [reloc @RWD00]
E8A499FDFF call System.TimeSpan:IntervalFromDoubleTicks(double):System.TimeSpan
90 nop
4883C428 add rsp, 40
C3 ret
; Total bytes of code: 26Now: ; Method Program:Test():System.TimeSpan:this
B880F0FA02 mov eax, 0x2FAF080
C3 ret
; Total bytes of code: 6The JIT change caused some positive diffs in asm.libraries_tests.pmi.windows.x64.checked (because it triggered inlining in places where e.g. "cns op cns" expressions were not recognized as constant args): coreclr_tests.pmi.windows.x64.checked.mch:Detail diffslibraries.pmi.windows.x64.checked.mch:Detail diffslibraries_tests.pmi.windows.x64.checked.mch:Detail diffs
|
AndyAyersMS
approved these changes
Aug 30, 2021
ghost
locked as resolved and limited conversation to collaborators
Member
Author
|
This PR optimized System.Tests.Perf_TimeSpan.FromSeconds but auto-filer didn't catch it, cc @DrewScoggins
|
Member
|
By default we exclude tests is they have an average less than .2ns. I cannot seem to find the discussion that we had about this, but maybe @tannergooding and @adamsitnik know where that is. Although after looking at the source code I did discover a bug, as we should file issues if we go from a value above .2ns to some value below it. I have fixed this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small change to optimize
TimeSpan.FromXapis for constant input 🙂. I was just randomly inspecting various APIs when constant args are passed to find missing opportunities.Was:
Now:
The JIT change caused some positive diffs in asm.libraries_tests.pmi.windows.x64.checked (because it triggered inlining in places where e.g. "cns op cns" expressions were not recognized as constant args):
coreclr_tests.pmi.windows.x64.checked.mch:
Detail diffs
libraries.pmi.windows.x64.checked.mch:
Detail diffs
libraries_tests.pmi.windows.x64.checked.mch:
Detail diffs