Update for rails 6 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some ruby 2.7 kwargs warnings and some some other test warnings
Contributor
Author
|
I am a bit confused by these errors. It seems like the rails migration version number is not being generated correctly, but the rails generators that this gem uses don't exist in rail master anymore and I am not sure that these tests where working prior to this change. since we never tested on rails > 6.0.0.rc1 @zerowidth do you have any ideas? |
HParker
force-pushed
the
update-for-rails-6
branch
from
eaef217 to
8231838
Compare
HParker
force-pushed
the
update-for-rails-6
branch
from
8231838 to
3ee4ca9
Compare
Member
|
Released as 0.5.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few updates that cleanup the output when running this gems tests under rails 6.0 and ruby 2.7
They are almost all small test update, but this does include an update that removes a call to a deprecated api in
8cfaed9