Skip to content

Conversation

@GeoffreyBooth
Copy link
Collaborator

@cosmicexplorer @lydell This fixes the tests that have been failing in Windows. #4727.

@GeoffreyBooth GeoffreyBooth requested a review from lydell October 3, 2017 05:05
Copy link
Collaborator

@lydell lydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. 👍

@GeoffreyBooth GeoffreyBooth merged commit 694e69d into jashkenas:master Oct 3, 2017
@GeoffreyBooth GeoffreyBooth deleted the cosmicexplorer/fix-windows-test-failures branch October 3, 2017 05:19
GeoffreyBooth added a commit to GeoffreyBooth/coffeescript that referenced this pull request Dec 2, 2017
@GeoffreyBooth GeoffreyBooth mentioned this pull request Dec 2, 2017
GeoffreyBooth added a commit that referenced this pull request Dec 3, 2017
* First attempt at AppVeyor for CS1

* Update NPM for Node < 4

* Backport #4731, fix for test failing in Windows

* Don't install NPM for Node-latest; cache node_modules

* Polyfill os.tmpdir for Node 0.8, update Travis to support Node 0.8

* Try to make Travis Node 0.8 happen

* Try different batch syntax

* Output NPM version if we install a 2.x version; never return a nonzero exit code if we skip NPM upgrade

* Try another syntax

* Fix syntax for latest Node

* Fix Windows batch syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants