Skip to content

Conversation

@GeoffreyBooth
Copy link
Collaborator

@GeoffreyBooth GeoffreyBooth commented Feb 3, 2018

Fixes #4877: Output ES2018 versions of ** and **= operators.

You can’t do odd things like !2 ** 2 or ~1 ** 5 in JavaScript, so I removed those tests. (Wrap the left side in parentheses and it’ll work.) I suppose technically this is a breaking change, but the test is really just testing order of operations and the examples seem unlikely to exist in production code.

These operators are only supported in Node 7.5+.

@GeoffreyBooth
Copy link
Collaborator Author

I’ve updated this to account for #5003. I think this should be ready now. @zdenko do you have any notes?

I’d like to resolve #5014 and any other open issues first in a 2.2.4 patch release, then merge in all the enhancements that are ready and release them in a 2.3.0. So @zdenko if you think this PR looks good, please just add a comment saying so, and we can merge it into master once 2.2.4 is done.

@zdenko
Copy link
Collaborator

zdenko commented Mar 16, 2018

LGTM 👍

@aminland
Copy link

aminland commented Mar 25, 2018

Should we wait for this to be stage 4 first? otherwise you have to use the plugin transform-exponentiation-operator unless we don't care about IE anymore...

@GeoffreyBooth
Copy link
Collaborator Author

@GeoffreyBooth
Copy link
Collaborator Author

This feature doesn’t require a rewrite of the Compatibility section, so it’s safe to merge in as is.

@GeoffreyBooth GeoffreyBooth merged commit 195a46a into jashkenas:master Mar 30, 2018
@GeoffreyBooth GeoffreyBooth deleted the exponentiation branch March 30, 2018 07:47
This was referenced Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants