Update dependencies #5311
Merged
Update dependencies #5311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of babel/babel#11226 and because our
package.jsonloads the latest version of Babel, our tests were failing in Node 6--harmony. This PR locks down Babel at 7.7.7, the last version that doesn’t error in Node 6--harmony, to get our tests and CI passing again.When/if Babel fixes their bug, we can update to the latest version of Babel again. If they decide to drop support for Node 6, we might need to do the same. Per babel/babel#10747, Babel 8 will only support Node 10.13+.